Skip to content

1MSG-156: enforce generated SDK quality and contract gates - #1

Draft
alibek-seksenali wants to merge 9 commits into
mainfrom
codex/1msg-156-quality-standard
Draft

alibek-seksenali wants to merge 9 commits into
mainfrom
codex/1msg-156-quality-standard

Conversation

@alibek-seksenali

@alibek-seksenali alibek-seksenali commented Oct 12, 2026 •

Copy link
Copy Markdown

Adopt the 1MSG-156 generated SDK profile with a required, fail-closed quality workflow. The SDK now replays OpenAPI Generator 7.22.0 against the pinned public API contract, verifies checksums and compares the complete inventory of 115 generated paths. Negative tests prove changed, deleted and ignored/untracked generated output is rejected.

PHP: all 115 generated library files lint successfully; a Guzzle mock exercises real request serialization and model validation. Composer dependencies are locked. The producer fixes the generated sendLocationRequest helper collision without changing the public operation.

The authored quality code uses sealed shared preset 1.0.11, frozen dependency installation, formatting/static lint, Knip production/full graphs, duplication checks and documented functions. Generated native code is validated by its native toolchain and reproducible producer. Existing placeholder/generated tests that did not execute contracts are replaced by offline behavioral checks where applicable.

Prior full generator/native validation: upstream shared preset tests 52/52; authored-code gates; clean generation replay and all drift-negative fixtures; native checks described above. GitHub Actions will independently execute the same required aggregate. No release, publication, deployment or merge was performed. Matching compatibility transforms and sync preservation are included in the 1msg-api PR for this task.

Task: https://plane.1msg.io/1msg/browse/1MSG-156/

Current source-coverage checkpoint 5d73db01edf4de1415850034b833db6134a9f08f covers authored JS/JSX/MJS/CJS in CI and the actual installed hook. TS/TSX/MTS/CTS additions are explicitly rejected until a strict program is configured; the repository retains its native SDK profile. Real disposable commits prove every extension is rejected for its intended diagnostic and corrected JavaScript commits successfully.

All seven local tooling gates pass: source/documentation guards, formatting, static lint, Knip production/full and duplicate runtime/full checks. The actual pre-commit hook passes. Shared preset1.0.11 and its52-test proof, generated/native sources and baseline metadata are unchanged. Hosted validation on this SHA passed: contract, quality-required.

Draft PR only; no merge, release, publication or deployment. The aggregate check does not by itself establish server-side required-check enforcement.

Suppression scanner and hook correction

Commit ff82c3c8784cbb05915e8fdb0a48fce39435362f adopts sealed preset 1.0.12. Parsed template/regex/JSX tokens prevent false directive reports and preserve real suppression checks within expressions and after templates. All 57 shared regression tests pass, including the real guard CLI and staged-file coverage tests. The complete seal was verified and historical baseline files were unchanged.
The actual installed pre-commit fixture passes: invalid authored extensions are rejected and corrected sources are accepted. A coverage preflight validates declared generated files and the sealed preset before ESLint suppresses ignored-file warnings; arbitrary authored ignores still fail.
The real commit hook passed without altering verified source hashes. Hosted checks must pass on this commit; earlier successes do not certify this new head. Existing incomplete adoption and addressed exceptions remain as documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant