Repository navigation
portal読み取り専用DB接続の独立設定を準備 - #202
Merged
Merged
Conversation
… into codex/portal-readonly-db-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
portal記事の取り込みで、cross-searchの検索DBユーザーをportal DBにも使って権限エラーになっています。読み取り専用ユーザーを設定できるよう、PORTAL_DB_USERNAME/PASSWORD/PORT/SOCKETを独立指定可能にします。
未指定値は既存設定へフォールバックし、明示的な空値は保持します。portal接続ではURL指定を無効にして、検索DBのDB_URLによる資格情報・接続先の上書きを防ぎます。専用URLも追加せず、既存のログ秘匿化が認識する個別password設定を使います。.env.exampleに秘密値を含まない設定例を追加しました。
これは接続設定の準備です。本番のDBユーザー作成・権限付与・認証情報変更は含みません。読み取り専用アカウントの準備後に設定する必要があります。
検証: 独立値・従来値・空値・URL経由の混線防止の新規5テスト24 assertions(Unit全6件25 assertions)成功、Pint・PHPStan成功。