From cd7e4907a0e8ad9b78f2af42f70e89f240d5dd93 Mon Sep 17 00:00:00 2001 From: Tim Haasdyk Date: Wed, 11 Nov 2026 12:59:45 +0100 Subject: [PATCH] Accept 429 when re-triggering a running sync in delete-during-sync tests Since #2960, FwHeadless answers a sync trigger for a project that is already syncing with 429. The two DuringSyncInProgress tests re-trigger after 3s to make sure a sync is running, so they always failed on that call. A 429 there is exactly the state the tests want. Co-Authored-By: Claude Opus 5.5 --- backend/Testing/ApiTests/DeleteProjectTests.cs | 4 ++-- backend/Testing/FwHeadless/FwHeadlessTestHelpers.cs | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/backend/Testing/ApiTests/DeleteProjectTests.cs b/backend/Testing/ApiTests/DeleteProjectTests.cs index d429b9c242..ca8a5f086b 100644 --- a/backend/Testing/ApiTests/DeleteProjectTests.cs +++ b/backend/Testing/ApiTests/DeleteProjectTests.cs @@ -212,7 +212,7 @@ public async Task DeleteProject_DuringSyncInProgress_FwHeadlessReturnsConflict() // Act // wait a bit to ensure the sync is actually in progress await Task.Delay(3000); - await FwHeadlessTestHelpers.TriggerSync(HttpClient, projectId); + await FwHeadlessTestHelpers.EnsureSyncRunningOrQueued(HttpClient, projectId); response = await HttpClient.DeleteAsync($"api/project/{projectId}"); // Assert @@ -344,7 +344,7 @@ public async Task SoftDeleteProject_DuringSyncInProgress_ReturnsGqlError() // Act // wait a bit to ensure the sync is actually in progress await Task.Delay(3000); - await FwHeadlessTestHelpers.TriggerSync(HttpClient, projectId); + await FwHeadlessTestHelpers.EnsureSyncRunningOrQueued(HttpClient, projectId); response = await ExecuteGql($$""" mutation { softDeleteProject(input: { projectId: "{{projectId}}" }) { diff --git a/backend/Testing/FwHeadless/FwHeadlessTestHelpers.cs b/backend/Testing/FwHeadless/FwHeadlessTestHelpers.cs index 3d752fa5ee..6efdbfb3af 100644 --- a/backend/Testing/FwHeadless/FwHeadlessTestHelpers.cs +++ b/backend/Testing/FwHeadless/FwHeadlessTestHelpers.cs @@ -1,3 +1,4 @@ +using System.Net; using System.Net.Http.Json; using LexCore.Sync; using Testing.Fixtures; @@ -23,6 +24,16 @@ public static async Task TriggerSync(HttpClient httpClient, Guid projectId) result.ShouldBeSuccessful(); } + /// + /// Like , but also accepts the 429 FwHeadless returns when a sync is already running. + /// + public static async Task EnsureSyncRunningOrQueued(HttpClient httpClient, Guid projectId) + { + var result = await httpClient.PostAsync($"api/fw-lite/sync/trigger/{projectId}", null); + if (result.StatusCode == HttpStatusCode.TooManyRequests) return; + result.ShouldBeSuccessful(); + } + public static async Task CancelSync(HttpClient httpClient, Guid projectId) { var result = await httpClient.PostAsync($"api/fw-lite/sync/cancel/{projectId}", null);