Perf regression in object destructuring with default values referencing other destructured members

[damienmortini]

VS Code Version:

• Version: 1.66.2 (user setup)
• Version: 1.67.0-insider (user setup)

OS:

• Windows_NT x64 10.0.22000

Steps to Reproduce:

1. Open this code

class GLTexture {
  constructor({
    gl,
    width,
    height,
    target = gl.TEXTURE_2D,
    internalFormat = gl.RGBA8 || gl.RGBA,
    format = gl.RGBA,
    type = gl.UNSIGNED_BYTE,
    autoGenerateMipmap = false,
    minFilter = autoGenerateMipmap ? gl.LINEAR_MIPMAP_LINEAR : gl.LINEAR,
    magFilter = gl.LINEAR,
    wrapS = gl.REPEAT,
    wrapT = gl.REPEAT,
  }) {
  }
}

2. See that after switching tabs or hovering on a property that IntelliSense isn't working and Loading IntelliSense Status in status bar starts spinning forever

I tried to isolate the issue that seems to be related to operators in constructor, but not always. Sometimes, it appears by commenting/uncommenting other lines.

[damienmortini]

Small Update -

I found a better isolation of the issue, it seems there is a hierarchy loop issue, the more properties depending on value1 you add, the slower it'll get until eventually it never loads.
If a default value is assigned to value1 everything works as expected.

class MyClass {
  constructor({
    value1,
    test1 = value1.test1,
    test2 = value1.test2,
    test3 = value1.test3,
    test4 = value1.test4,
    test5 = value1.test5,
    test6 = value1.test6,
    test7 = value1.test7,
    test8 = value1.test8,
    // ...
  }) {}
}

[mjbvz]

Thanks for the self-contained example! Was able to confirm using 4.7.0-dev.20220430

[typescript-bot]

👋 Hi, I'm the Repro bot. I can help narrow down and track compiler bugs across releases! This comment reflects the current state of this repro running against the nightly TypeScript.

---

Comment by Damien Mortini (@damienmortini)

❌ Failed: -

• 'value1' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
• Binding element 'value1' implicitly has an 'any' type.

⚠️ Way slower than historical runs

Historical Information

Version	Reproduction Outputs	Time
4.6.2	❌ Failed: - 'value1' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer. Binding element 'value1' implicitly has an 'any' type.	⚠️ Way slower
4.2.2, 4.3.2, 4.4.2, 4.5.2	❌ Failed: - 'value1' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer. Binding element 'value1' implicitly has an 'any' type.

[typescript-bot]

The change between 4.5.2 and 4.6.2 occurred at 831b770.

[andrewbranch]

Repro executes in ~1 second in 4.5 and earlier, ~120 seconds in 4.6 and later 😅

Caused by #46266

[ahejlsberg]

Doesn't appear to have anything to do with class constructors. This suffers from the same issue:

function foo({
    value1,
    test1 = value1.test1,
    test2 = value1.test2,
    test3 = value1.test3,
    test4 = value1.test4,
    test5 = value1.test5,
    test6 = value1.test6,
    test7 = value1.test7,
    test8 = value1.test8,
    // ...
}) {}

Something appears to have exponentially rising cost. I'll research...