Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.
This repository was archived by the owner on May 22, 2025. It is now read-only.

Skipping an @implements can cause misoptimization with typed optimizations #1072

Description

@evmar

In some cases we back off from emitting an "@implements" tag. But with typed optimizations, every "@implements" is potentially load-bearing.

At the TS level, every "implements" is always optional. At the Closure level, it is dangerous to ever leave out an "@implements". We have no good user-facing way of reconciling these two.

I think we should instead say something like: if you ever write "implements" in TS, we always emit an "@implements", and if the latter fails for some reason you should delete the "implements" from the TS side.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

typed optimizationsBugs that only cause problems with typed optimizations

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions