From 24156f4c349b100b3e9f098175ca6f5b584e70b6 Mon Sep 17 00:00:00 2001 From: wangtiance Date: Sun, 22 Nov 2026 08:40:40 +0800 Subject: [PATCH] [test] canvas: align nightly fixtures with current lock semantics ## summary - Establish version-checked API locks after the first-open lock release before asserting subject editing and media restrictions. - Require accepted for asynchronous generation submission receipts. ## validation Subject editing, subject media and bilingual video capability browser workflows passed with isolated fixtures and Chromium 145. Syntax, browser manifest and diff checks passed. No real models were called. Pre-commit is skipped per user authorization. --- tests/browser/subject_node_editing.mjs | 40 ++++++++++++++++++++++-- tests/browser/subject_node_media.mjs | 40 ++++++++++++++++++++++-- tests/browser/video_capability_roles.mjs | 2 +- 3 files changed, 75 insertions(+), 7 deletions(-) diff --git a/tests/browser/subject_node_editing.mjs b/tests/browser/subject_node_editing.mjs index 93057748e..d188ff312 100644 --- a/tests/browser/subject_node_editing.mjs +++ b/tests/browser/subject_node_editing.mjs @@ -11,9 +11,14 @@ const browser = await chromium.launch({ : {}), args: ["--no-sandbox"], }); -const page = await browser.newPage({ locale: "zh-CN", viewport: { width: 1700, height: 1000 } }); +const page = await browser.newPage({ + locale: "zh-CN", + viewport: { width: 1700, height: 1000 }, +}); // Skip the first-run model setup welcome; it covers the canvas. -await page.addInitScript(() => localStorage.setItem("opendirector.modelSetup.v1", "dismissed")); +await page.addInitScript(() => + localStorage.setItem("opendirector.modelSetup.v1", "dismissed"), +); page.setDefaultTimeout(15000); const errors = []; page.on("pageerror", (error) => errors.push(error.message)); @@ -73,7 +78,7 @@ try { ); const locked = { ...createNode("subject", { x: 1180, y: 200 }, { title: "锁定主体" }), - locked: true, + locked: false, }; const saved = await importWorkspaceDocument({ ...createDocument("Subject UI " + crypto.randomUUID().slice(0, 8)), @@ -95,6 +100,35 @@ try { await page.goto(base + "/ai-tool/ai-canvas/" + f.id + mode); await page.getByText("已保存到本机", { exact: true }).waitFor(); const node = (id) => page.locator(`.react-flow__node[data-id="${id}"]`); + // Imported locks are intentionally released on first open (#415). + // Exercise a current API lock after that open-time policy has completed. + await page.waitForFunction( + (id) => + localStorage.getItem(`opendirector.legacyLocksReleased:${id}`) === "1", + f.id, + ); + await page.evaluate(async ({ id, locked }) => { + const { creationClient } = await import("/src/backend/creationClient.ts"); + const client = creationClient(id); + await client.refresh(); + const item = client.snapshot.canvasItems.find( + (item) => item.id === locked, + ); + const receipt = await client.command( + "canvas.update", + { + itemId: locked, + locked: true, + }, + [{ objectType: "canvas_item", id: item.id, revision: item.revision }], + ); + if (receipt.status !== "applied") throw Error(JSON.stringify(receipt)); + if ( + !client.snapshot.canvasItems.find((item) => item.id === locked)?.locked + ) + throw Error("Subject lock was not persisted"); + }, f); + await node(f.locked).locator(".cw-node-locked").waitFor(); const summary = page.locator(".cw-node-info-trigger"); const summaryPanel = page.getByRole("tooltip", { name: "节点信息", diff --git a/tests/browser/subject_node_media.mjs b/tests/browser/subject_node_media.mjs index 032204fd4..2baca60f6 100644 --- a/tests/browser/subject_node_media.mjs +++ b/tests/browser/subject_node_media.mjs @@ -33,9 +33,14 @@ const browser = await chromium.launch({ : {}), args: ["--no-sandbox"], }); -const page = await browser.newPage({ locale: "zh-CN", viewport: { width: 1500, height: 1050 } }); +const page = await browser.newPage({ + locale: "zh-CN", + viewport: { width: 1500, height: 1050 }, +}); // Skip the first-run model setup welcome; it covers the canvas. -await page.addInitScript(() => localStorage.setItem("opendirector.modelSetup.v1", "dismissed")); +await page.addInitScript(() => + localStorage.setItem("opendirector.modelSetup.v1", "dismissed"), +); page.setDefaultTimeout(15000); const errors = []; page.on("pageerror", (error) => errors.push(error.message)); @@ -136,7 +141,7 @@ try { }, }, ), - locked: true, + locked: false, }; const savedDocument = await importWorkspaceDocument({ ...createDocument( @@ -163,6 +168,35 @@ try { await page.goto(`${base}/ai-tool/ai-canvas/${fixture.id}${""}`); await page.getByText("已保存到本机", { exact: true }).waitFor(); const node = (id) => page.locator(`.react-flow__node[data-id="${id}"]`); + // Imported locks are intentionally released on first open (#415). + // Exercise a current API lock after that open-time policy has completed. + await page.waitForFunction( + (id) => + localStorage.getItem(`opendirector.legacyLocksReleased:${id}`) === "1", + fixture.id, + ); + await page.evaluate(async ({ id, locked }) => { + const { creationClient } = await import("/src/backend/creationClient.ts"); + const client = creationClient(id); + await client.refresh(); + const item = client.snapshot.canvasItems.find( + (item) => item.id === locked, + ); + const receipt = await client.command( + "canvas.update", + { + itemId: locked, + locked: true, + }, + [{ objectType: "canvas_item", id: item.id, revision: item.revision }], + ); + if (receipt.status !== "applied") throw Error(JSON.stringify(receipt)); + if ( + !client.snapshot.canvasItems.find((item) => item.id === locked)?.locked + ) + throw Error("Subject lock was not persisted"); + }, fixture); + await node(fixture.locked).locator(".cw-node-locked").waitFor(); for (const [count, id] of fixture.images.entries()) { const card = node(id); assert.equal( diff --git a/tests/browser/video_capability_roles.mjs b/tests/browser/video_capability_roles.mjs index d36ac34a1..9fe784773 100644 --- a/tests/browser/video_capability_roles.mjs +++ b/tests/browser/video_capability_roles.mjs @@ -330,7 +330,7 @@ try { submitReceipt = await response.json(); assert.equal( submitReceipt.status, - "applied", + "accepted", JSON.stringify(submitReceipt), ); finished = await until(