From df5b10036347ae2627341aa99928276b8cc59d9e Mon Sep 17 00:00:00 2001 From: vitaliy Date: Fri, 6 Nov 2026 10:10:57 +0200 Subject: [PATCH 1/2] Test Playwright 1.65 with authenticated fixtures and Chrome 156 --- .github/workflows/ci.yml | 19 +++++- package-lock.json | 24 ++++---- package.json | 2 +- test/playwright/config.js | 9 ++- test/playwright/csp-worker.spec.js | 33 +++++++++-- test/playwright/interaction.spec.js | 90 +++++++++++++++++++++++++++++ 6 files changed, 156 insertions(+), 21 deletions(-) create mode 100644 test/playwright/interaction.spec.js diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8671e5f..edc1e81 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,13 +15,17 @@ permissions: jobs: test: - name: Node ${{ matrix.node }} + name: Node ${{ matrix.node }} / ${{ matrix.browser }} runs-on: ubuntu-latest timeout-minutes: 10 strategy: fail-fast: false matrix: node: ['24', '26'] + browser: [chromium] + include: + - node: '24' + browser: chrome-156 steps: - uses: actions/checkout@v6 - uses: actions/setup-node@v6 @@ -32,5 +36,18 @@ jobs: - run: npm test - run: npm run test:types - run: npx playwright install --with-deps chromium + if: matrix.browser == 'chromium' + - name: Install MageLens's pinned Chrome for Testing + if: matrix.browser == 'chrome-156' + env: + CHROME_VERSION: '156.0.8078.80' + CHROME_SHA256: b711c720f774be355197f32edf37e0651418ba036d92446ee2da19ac017540a7 + run: | + npx playwright install-deps chromium + curl --fail --location --output "$RUNNER_TEMP/chrome.zip" "https://storage.googleapis.com/chrome-for-testing-public/$CHROME_VERSION/linux64/chrome-linux64.zip" + echo "$CHROME_SHA256 $RUNNER_TEMP/chrome.zip" | sha256sum --check + unzip -q "$RUNNER_TEMP/chrome.zip" -d "$RUNNER_TEMP/mtc-chrome" + echo "MTC_CHROME_EXECUTABLE_PATH=$RUNNER_TEMP/mtc-chrome/chrome-linux64/chrome" >> "$GITHUB_ENV" + echo "MTC_CHROME_VERSION=$CHROME_VERSION" >> "$GITHUB_ENV" - run: npm run test:playwright - run: npm pack --dry-run diff --git a/package-lock.json b/package-lock.json index 35e7afb..cf2cc17 100644 --- a/package-lock.json +++ b/package-lock.json @@ -22,7 +22,7 @@ }, "devDependencies": { "@alpinejs/csp": "3.14.3", - "@playwright/test": "1.64.1", + "@playwright/test": "1.65.0", "@types/node": "24.19.2", "alpinejs": "3.17.4", "knockout": "3.5.1", @@ -339,13 +339,13 @@ } }, "node_modules/@playwright/test": { - "version": "1.64.1", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.64.1.tgz", - "integrity": "sha512-IaYGml/nSOiZWROfPtuIL7neuu9qDOZ3TNvNljUIrhDMxiGTgPjzj/g9p9RxpS2tSepPDRY+UwAaEeiKtUvIAg==", + "version": "1.65.0", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.65.0.tgz", + "integrity": "sha512-iGURLGuKDLakSEl7Pgfv8h7f+XLT+V861Wfhz0zlEl5nyFuKUopdkFBPKqTllTUp06aOwPuH8iuUEb3yp3MpbQ==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright": "1.64.1" + "playwright": "1.65.0" }, "bin": { "playwright": "cli.js" @@ -650,13 +650,13 @@ "license": "ISC" }, "node_modules/playwright": { - "version": "1.64.1", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.64.1.tgz", - "integrity": "sha512-HCrVhHr5QQuwYoswEUGTb7gGp522yflbv/ST8nF4sFWGuLjQCt17Q/EubpGGSNKYn1tsTCPZxqHhHCfVURu7UA==", + "version": "1.65.0", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.65.0.tgz", + "integrity": "sha512-F3AMWcR44qMBt4kq+6Kb6mX7bjGXshktKFOPULd7reED6ZJWevjbNRqysP7q+AATE9kdPEZBibex1BYsvpVoeA==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.64.1" + "playwright-core": "1.65.0" }, "bin": { "playwright": "cli.js" @@ -666,9 +666,9 @@ } }, "node_modules/playwright-core": { - "version": "1.64.1", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.64.1.tgz", - "integrity": "sha512-BC4s8y6SEVA6Q1rSxZTto8hI1KUI3xXlHGZgvGqP4IqPdI/a6FX9H29IDNz7vKo9l21b6LfYosScPL6M3xxyDQ==", + "version": "1.65.0", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.65.0.tgz", + "integrity": "sha512-vNSKgH6YqtN7cdT/L334zo0a+YwkrpicyrHJlWWPIm/Q+Nn2SWInil01oT0mbu96U4GgoRtCYQD9CzJQgju+lA==", "dev": true, "license": "Apache-2.0", "bin": { diff --git a/package.json b/package.json index e96e9a8..7795b12 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ }, "devDependencies": { "@alpinejs/csp": "3.14.3", - "@playwright/test": "1.64.1", + "@playwright/test": "1.65.0", "@types/node": "24.19.2", "alpinejs": "3.17.4", "knockout": "3.5.1", diff --git a/test/playwright/config.js b/test/playwright/config.js index fdb79f3..016fc4b 100644 --- a/test/playwright/config.js +++ b/test/playwright/config.js @@ -2,4 +2,11 @@ // SPDX-License-Identifier: MIT // License: see LICENSE in the repository root. -module.exports = {testDir: __dirname, testMatch: '*.spec.js', workers: 1, retries: 0, reporter: 'list', use: {browserName: process.env.MTC_BROWSER || 'chromium', headless: true}, outputDir: '../../artifacts/playwright'}; +module.exports = { + testDir: __dirname, testMatch: '*.spec.js', workers: 1, retries: 0, reporter: 'list', + use: { + browserName: process.env.MTC_BROWSER || 'chromium', headless: true, + launchOptions: process.env.MTC_CHROME_EXECUTABLE_PATH ? {executablePath: process.env.MTC_CHROME_EXECUTABLE_PATH} : {} + }, + outputDir: '../../artifacts/playwright' +}; diff --git a/test/playwright/csp-worker.spec.js b/test/playwright/csp-worker.spec.js index 0cb4458..65a4564 100644 --- a/test/playwright/csp-worker.spec.js +++ b/test/playwright/csp-worker.spec.js @@ -19,14 +19,30 @@ const authenticated = base.extend({ fixture.write(path.join(source, 'app/code')); const manifest = createManifest({source, roots: ['app/code']}); instrument({source, manifest, mappings: {'app/code': copy}}); - const server = http.createServer((req, res) => {if (!fixture.serve(req, res, copy)) res.writeHead(404).end();}); + const server = http.createServer((req, res) => { + if (req.url === '/login' && req.method === 'POST') { + res.setHeader('Set-Cookie', 'session=authenticated; Path=/admin; HttpOnly; SameSite=Lax'); + res.writeHead(204).end(); return; + } + if (req.url === '/administrator') { + res.setHeader('Content-Type', 'application/json'); + res.end(JSON.stringify({cookie: req.headers.cookie || ''})); return; + } + if (req.url === '/admin/csp.html') { + if (req.headers.cookie !== 'session=authenticated') { res.writeHead(401).end(); return; } + fixture.serve({url: '/csp.html'}, res, copy); return; + } + if (!fixture.serve(req, res, copy)) res.writeHead(404).end(); + }); await new Promise(resolve => server.listen(0, '127.0.0.1', resolve)); - try { await use({root, manifest, url: `http://127.0.0.1:${server.address().port}/csp.html`}); } + try { await use({root, manifest, url: `http://127.0.0.1:${server.address().port}/admin/csp.html`}); } finally { await new Promise(resolve => server.close(resolve)); fs.rmSync(root, {recursive: true, force: true}); } }, {scope: 'worker'}], login: [async ({browser, site}, use) => { const context = await browser.newContext(); + let state; try { + expect((await context.request.post(new URL('/login', site.url).href)).status()).toBe(204); const page = await context.newPage(); const errors = []; page.on('pageerror', error => errors.push(error.message)); await page.goto(site.url); @@ -34,18 +50,23 @@ const authenticated = base.extend({ await expect(page.locator('#count')).toHaveText('7'); expect(errors).toEqual([]); expect(fs.existsSync(path.join(site.root, 'hits'))).toBe(false); + state = await context.storageState(); } finally { await context.close(); } - await use(true); + await use(state); }, {scope: 'worker'}], - storageState: async ({login}, use) => { expect(login).toBe(true); await use({cookies: [], origins: []}); } + storageState: async ({login}, use) => use(login) }); const test = withTemplateCoverage(authenticated).extend({ templateCoverageOptions: async ({site}, use) => use({outputDir: path.join(site.root, 'hits')}) }); -test('worker login contexts run CSP bindings without adding coverage records', async ({page, site}) => { +test('worker login contexts run CSP bindings without adding coverage records', async ({page, context, site}) => { const errors = []; page.on('pageerror', error => errors.push(error.message)); - await page.goto(site.url); + expect((await context.cookies(site.url)).map(cookie => cookie.name)).toEqual(['session']); + const outside = new URL('/administrator', site.url).href; + expect(await context.cookies(outside)).toEqual([]); + expect(await (await context.request.get(outside)).json()).toEqual({cookie: ''}); + expect((await page.goto(site.url)).status()).toBe(200); await expect(page.locator('#count')).toHaveText('0'); await page.locator('#increment').click(); await expect(page.locator('#count')).toHaveText('1'); diff --git a/test/playwright/interaction.spec.js b/test/playwright/interaction.spec.js new file mode 100644 index 0000000..b3c1969 --- /dev/null +++ b/test/playwright/interaction.spec.js @@ -0,0 +1,90 @@ +// SPDX-FileCopyrightText: Private Entrepreneur Vitalii Boiko +// SPDX-License-Identifier: MIT +// License: see LICENSE in the repository root. + +'use strict'; +const {test, expect} = require('@playwright/test'); +const fs = require('node:fs'); +const os = require('node:os'); +const path = require('node:path'); +const http = require('node:http'); +const {createManifest, instrument, merge, readRecords} = require('../../lib'); +const {registerTemplateCoverage} = require('../../playwright'); + +test.beforeAll(async ({browser}) => { + const name = process.env.MTC_CHROME_EXECUTABLE_PATH ? 'chrome-for-testing' : browser.browserType().name(); + console.log(`Compatibility browser: ${name} ${browser.version()}; Playwright ${require('@playwright/test/package.json').version}`); + if (process.env.MTC_CHROME_VERSION) expect(browser.version()).toBe(process.env.MTC_CHROME_VERSION); +}); + +test('instrumentation preserves inert controls and rendered accessible names', async ({context, page}) => { + const root = fs.mkdtempSync(path.join(os.tmpdir(), 'mtc-interaction-')); + const source = path.join(root, 'source'), copy = path.join(root, 'copy'); + const html = `
+ +
+ + + + +Apply
OptionsUnrendered text
+ + +
`; + fs.mkdirSync(path.join(source, 'app/code'), {recursive: true}); + fs.writeFileSync(path.join(source, 'app/code/controls.html'), html); + const manifest = createManifest({source, roots: ['app/code']}); + instrument({source, manifest, mappings: {'app/code': copy}}); + const server = http.createServer((req, res) => { + if (req.url === '/alpine.js') { + res.setHeader('Content-Type', 'application/javascript'); + res.end(fs.readFileSync(require.resolve('alpinejs').replace(/module.cjs.js$/, 'cdn.js'))); return; + } + if (!['/original', '/instrumented'].includes(req.url)) { res.writeHead(404).end(); return; } + res.setHeader('Content-Type', 'text/html'); + const body = req.url === '/original' ? html : fs.readFileSync(path.join(copy, 'controls.html'), 'utf8'); + res.end('' + body); + }); + await new Promise(resolve => server.listen(0, '127.0.0.1', resolve)); + const coverage = await registerTemplateCoverage(context, {outputDir: path.join(root, 'hits')}); + const errors = []; page.on('pageerror', error => errors.push(error.message)); + try { + for (const route of ['original', 'instrumented']) { + await page.goto(`http://127.0.0.1:${server.address().port}/${route}`); + await expect(page.locator('#count')).toHaveText('0'); + for (const action of [ + () => page.locator('#name').fill('blocked', {timeout: 300}), + () => page.locator('#choice').selectOption('b', {timeout: 300}), + () => page.locator('#checked').check({timeout: 300}), + () => page.locator('#apply').click({timeout: 300}) + ]) await expect(action()).rejects.toThrow(/inert/); + await expect(page.locator('#name')).toHaveValue(''); + await expect(page.locator('#choice')).toHaveValue('a'); + await expect(page.locator('#checked')).not.toBeChecked(); + await expect(page.locator('#count')).toHaveText('0'); + await page.getByRole('button', {name: 'Unlock', exact: true}).click(); + await page.locator('#name').fill('updated'); + await expect(page.locator('#echo')).toHaveText('updated'); + await page.locator('#choice').selectOption('b'); + await expect(page.locator('#choice')).toHaveValue('b'); + await page.locator('#checked').check(); + await expect(page.locator('#checked')).toBeChecked(); + await page.getByRole('button', {name: 'Apply Options', exact: true}).click(); + await expect(page.locator('#count')).toHaveText('1'); + } + expect(errors).toEqual([]); + await coverage.stop(); + const records = readRecords(path.join(root, 'hits')); + expect(records).toHaveLength(1); + const entry = manifest.templates[0]; + const click = id => entry.statements.find(statement => statement.binding === '@click' && + entry.source.split('\n')[statement.start.line - 1].includes(`id="${id}"`)); + expect(records[0].hits[entry.id][click('apply').id]).toBe(1); + expect(records[0].hits[entry.id][click('unused').id] || 0).toBe(0); + expect(merge(manifest, records).templates[0].unsupportedDirectives || []).toEqual([]); + expect(fs.readFileSync(path.join(source, 'app/code/controls.html'), 'utf8')).toBe(html); + } finally { + await new Promise(resolve => server.close(resolve)); + fs.rmSync(root, {recursive: true, force: true}); + } +}); From cc01782ddc7fe624ab7d0573a58ab47e66c8b094 Mon Sep 17 00:00:00 2001 From: Vitalii Boiko Date: Fri, 6 Nov 2026 09:34:56 +0000 Subject: [PATCH 2/2] Release 1.5.4: qualify Playwright 1.65 compatibility --- CHANGELOG.md | 4 ++++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e971a55..1ce26e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ License: see LICENSE in the repository root. # Changelog +## 1.5.4 - 2026-11-06 + +- Verify Playwright 1.65 compatibility with Chrome for Testing 156.0.8078.80, including inert controls, rendered accessible names and authenticated CSP fixtures with path-scoped cookies. + ## 1.5.3 - 2026-10-29 - Verify Node.js 26 compatibility alongside Node.js 24 for template analysis, Playwright integration and TypeScript declarations. diff --git a/package-lock.json b/package-lock.json index cf2cc17..01b62e2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@vitaliiboiko/magento-template-coverage", - "version": "1.5.3", + "version": "1.5.4", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@vitaliiboiko/magento-template-coverage", - "version": "1.5.3", + "version": "1.5.4", "license": "MIT", "dependencies": { "@babel/core": "7.29.7", diff --git a/package.json b/package.json index 7795b12..10883d2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@vitaliiboiko/magento-template-coverage", - "version": "1.5.3", + "version": "1.5.4", "description": "Magento 2 HTML/PHTML template execution coverage for Cypress and Playwright, including Knockout, Hyva/Alpine and inline JavaScript", "license": "MIT", "repository": {