Skip to content

In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Daf 1 of Meschtas after Brachos #207

Description

@elazarrosenthal

I fixed this as part of my pull request
Newyerushalmi Code to implement New Yerushalmi Yomi
#206
But incase you dont want to accept that request
Beawre that the current implimentation of YerushalmiYomiCalculator -> getDafYomiYerushalmi()
For Mesectas after the first will returen LastMisectah , LastMisectaMaxDaf+1
for the 1st daf of a new mesechta

The fix I did is on line 100 if (total <= BLATT_PER_MASSECTA[j]) {

replace <= with <

Anotherr fix would be to start the daf counter from not 0
but I did not try totest such a solution

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions