From 3e1ae3f4ad75c71150f5f4f8e5422bce907045fd Mon Sep 17 00:00:00 2001 From: ASDAlexander77 Date: Thu, 19 Nov 2026 13:24:54 +0000 Subject: [PATCH 1/2] Android tests: 00weak_field.ts is not built under -mm=rc, which refuses @weak The release run for v0.0-pre-alpha131 failed in "Build Android tests (x86_64)" on this one program: `@weak` is refused under rc by design (own spec 93), and ctest registers the test under gc, none and own only. The Android runner compiles every test of the suite under every model, so it needs the same exception in android_skips.txt. Co-Authored-By: Claude Opus 5.5 --- tslang/test/android/android_skips.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tslang/test/android/android_skips.txt b/tslang/test/android/android_skips.txt index 7193b6b8f..e9f72e78c 100644 --- a/tslang/test/android/android_skips.txt +++ b/tslang/test/android/android_skips.txt @@ -9,3 +9,6 @@ json.ts none # (default library) builds a 100000-character st # fails natively under the same model too (not run natively under it by ctest) 00global_interface_initializer.ts own # asserts "a field read" (native own: the same assert) + +# refused by design under the model, as in ctest (which registers them under the other models only) +00weak_field.ts rc # '@weak' is not supported under -mm=rc (own spec 93): ctest runs it under gc, none and own From 406fe08f13da165baa0d3f6e1322b428db0c3d9d Mon Sep 17 00:00:00 2001 From: ASDAlexander77 Date: Thu, 19 Nov 2026 13:31:48 +0000 Subject: [PATCH 2/2] Android test workflow: the default library's tests as of the release it tests A pull request that changes the Android runner tests the latest published release's package with that release's tester tests, but cloned the default library at today's main: a test added since (typed_array_methods.ts, DefaultLib #105) was built with alpha130's compiler and library, which lack it, and failed under gc, rc and none. create-release.yml builds a package's default library from that repository's main when the tag is pushed, so the tests are now taken from main as it was at the tag's date (alpha130: 6806d40). Co-Authored-By: Claude Opus 5.5 --- .github/workflows/test-android.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/test-android.yml b/.github/workflows/test-android.yml index cca7936ad..7e19d7b7b 100644 --- a/.github/workflows/test-android.yml +++ b/.github/workflows/test-android.yml @@ -67,6 +67,7 @@ jobs: shell: pwsh env: GH_TOKEN: ${{ github.token }} + DEFAULTLIB_SHA: ${{ inputs.defaultlib_sha }} run: | # every release is a pre-release, and GitHub's "latest" leaves those out: take the newest $tag = gh release list --repo ${{ github.repository }} --exclude-drafts --limit 1 --json tagName --jq '.[0].tagName' @@ -80,6 +81,18 @@ jobs: if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } git checkout $tag -- tslang/test/tester/tests tslang/test/tester/CMakeLists.txt if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } + # ...and the default library's tests as they were for it: create-release.yml builds the + # package's default library from that repository's main when the tag is pushed, so take + # main as it was at the tag's date (a test added since needs a library the package lacks) + if (-not $env:DEFAULTLIB_SHA) { + $tagDate = git for-each-ref "refs/tags/$tag" --format='%(taggerdate:iso-strict)' + if (-not $tagDate) { $tagDate = git log -1 --format=%cI $tag } + $sha = git -C TypeScriptCompilerDefaultLib rev-list -n 1 --before="$tagDate" origin/main + if ($LASTEXITCODE -ne 0 -or -not $sha) { Write-Error "no Default Library commit before $tagDate"; exit 1 } + Write-Host "Default Library at $($tag)'s date ($tagDate): $sha" + git -C TypeScriptCompilerDefaultLib checkout --detach $sha + if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } + } - name: Unpack the package shell: pwsh